Please standardize Screen saver DBus interfaces

[Ali Abdallah]

Bastien Nocera wrote:
> On Tue, 2009-05-19 at 15:08 +0200, André Gillibert wrote:
>   
>> Ali Abdallah wrote:
>>
>>     
>>> Lubos Lunak wrote:
>>>       
>>>>  Actually, the way to inhibit the screensaver on X was standardized  
>>>> ages ago -
>>>> it's XResetScreensaver(), in Xlib. It resets the user inactivity  
>>>> counter, it prevents DPMS from activating,
>>>>         
>>> I see this X standard which was implemented ages ago not being respected
>>> by movie players
>>> (xine, mplayer, totem, ...).
>>>
>>>       
> <snip>
>   
>> From totem source code (lib/totem-scrsaver.c):
>>     
>>> screensaver_disable_x11 (TotemScrsaver *scr)
>>> [...]
>>>         XSetScreenSaver(GDK_DISPLAY(), 0, 0,
>>>                        DontPreferBlanking, DontAllowExposures);
>>> [...]
>>> }
>>>       
>> vlc (and totem too), unlike mplayer and xine, disable the screen saver
>> when it's loaded, and enable it when it's exited (that's what I feel
>> when I read the source code).
>>     
>
> That's wrong. Totem uses XSetScreenSaver when:
> 1) There's no screensaver on the D-Bus that it supports (eg. no
> gnome-screensaver)
> 2) It's not compiled with XTest support, or XTest isn't available.
>
> Eg. Totem uses XSetScreenSaver when everything else fails.
>
>   

Which should be the other way round.

> _______________________________________________
> xdg mailing list
> xdg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xdg
>   


-- 
Send unlimited messages for free to all destinations with DBus.

http://www.freedesktop.org/wiki/Software/dbus