DBus service for screenshots.

[Jasper St. Pierre]

On Fri, Sep 25, 2015 at 8:09 AM, Boudhayan Gupta <bgupta at kde.org> wrote:
... snip ...

> The use-case for StartAgent is simple - what if a supervisor (such as
> the compositor on Wayland) is providing the service, but a separate
> application (agent) provides manipulation, editing, saving etc.
> functionality?

So what's the expected flow here? You don't have any way of providing
a filename to the Agent for further manipulation and publishing. Is
the Agent expected to show all recently taken thumbnails in a grid or
similar, and have the user select them? What's the expectation here?

Your proposed protocol also has a race condition -- if I call one of
the Screenshot methods twice in succession, it's impossible to know
which call maps to which signal. Please use a standard out parameter
for this.

Does the chosen filename have any pattern to it?

Your API also doesn't document if the screenshot will include padding
and a border for window-specific screenshots, or if it will simply
contain the window itself.

What image format will the screenshot be in? Probably one of PNG or
JPEG, but is there any guarantee on that?

I think we should also make some guarantees about where the file is
roughly expected to be placed, like to say it's placed in
$XDG_PICTURES_DIR.

-- 
  Jasper