[xorg-bugzilla-noise] [Bug 1045] New: ddx.txt doesn't reflect the current policy for GC wrappers

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
 
https://freedesktop.org/bugzilla/show_bug.cgi?id=1045        
   
           Summary: ddx.txt doesn't reflect the current policy for GC
                    wrappers
           Product: xorg
           Version: CVS_head
          Platform: PC
        OS/Version: FreeBSD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Documentation
        AssignedTo: xorg-bugzilla-noise at freedesktop.org
        ReportedBy: anholt at FreeBSD.org


The current policy for GC wrappers, as keithp explained it to me, is:

The contents of GC funcs/ops vectors (the structs) may not change after they are
in use, i.e. CreateGC.
GC funcs may change the funcs and ops vectors (the pointers) for the GC.
GC ops may change the ops vectors for the GC.

Because of this, the rule for GC wrapping is:

In a GC func, unwrap funcs and ops, call down, pull funcs and ops back out of
the GC (to maintain the wrapping chain if the call down resulted in
modification), and rewrap funcs and ops.
In a GC op, unwrap ops, call down, pull ops back out, and rewrap ops.

The documentation in section 5.8.2 of the DDX document seems both ambiguous and
not in line with this policy, and needs to be updated.        
   
   
--         
Configure bugmail: https://freedesktop.org/bugzilla/userprefs.cgi?tab=email       
   
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.