[xorg-bugzilla-noise] [Bug 1057] [PATCH] GLX looks for DRI drivers in wrong dir on AMD64 (and others?)

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
 
https://freedesktop.org/bugzilla/show_bug.cgi?id=1057        
   




------- Additional Comments From mharris at www.linux.org.uk  2004-08-12 23:21 -------
(In reply to comment #4)
> (In reply to comment #2)
> > amd64, ppc64, s390x are all the same for libdir beign "lib64".  Both the current
> > CVS glx code is broken with ProjectRoot, as well as the attached patch.  Imake
> > defines BUILDMODULESDIR as a base for the modules to get installed into.
> > 
> > A patch that does something like this might work better, and fix ProjectRoot
> > at the same time:
> > 
> > -   GLX_DEFS = GlxDefines VidModeExtensionDefines
> > +   GLX_DEFS = GlxDefines VidModeExtensionDefines \
> > +              -DDEFAULT_DRIVER_DIR=\"$(BUILDMODULEDIR)\"
> > 
> > Untested yet however.  If someone else hasn't tested this yet when I get
> > to testing AMD64, I'll test it.
> > 
> 
> I don't fully understand what you think ProjectRoot should be..

ProjectRoot defaults to /usr/X11R6, however it is redefineable to anywhere
else.  All files that normally install in /usr/X11R6, aren't hard coded
to be there, but rather they are relative to ProjectRoot, so if you move
ProjectRoot to say /opt/X11, all files will install there instead.  When this
happens, and NothingOutsideProjectRoot is set, all stuff should get installed
in ProjectRoot/... at make install time, and everything looking for files
at runtime should be relative to ProjectRoot as well (such as looking for
server modules).

> How about this:
> 
> -     GLX_DEFS = GlxDefines VidModeExtensionDefines
> +     GLX_DEFS = GlxDefines VidModeExtensionDefines \
> +               -DDEFAULT_DRIVER_DIR=\"$(MODULEDIR)/dri\"
> 
> Tested on AMD64.
 
Yes, this looks correct, I picked the wrong directive in my sleepiness.

        
   
   
--         
Configure bugmail: https://freedesktop.org/bugzilla/userprefs.cgi?tab=email       
   
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.