[xorg-bugzilla-noise] [Bug 640] New: Moving of libXThrStub into libX11

[bugzilla-daemon at pdx.freedesktop.org]

http://pdx.freedesktop.org/cgi-bin/bugzilla/show_bug.cgi?id=640

           Summary: Moving of libXThrStub into libX11
           Product: xorg
           Version: CVS_head
          Platform: PC
        OS/Version: FreeBSD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Lib/Xlib
        AssignedTo: xorg-bugzilla-noise at freedesktop.org
        ReportedBy: eta at lclark.edu


Background: On OpenBSD, and on old FreeBSD, libc lacks pthread stubs.  This is a
problem because libX11 needs to support threading, but shouldn't cause all X
programs to be linked against the threading library.  The solution is
libXThrStub (UIThrStubs.c), which provides weak symbols to stub threading
functions, which are ignored if the application links against the thread library.

However, it seems silly to me to have this as a separate library.  There are two
consumers of it: libX11 and libGL.  Anyone linking against libGL is linking
against libX11 anyway.  Moving the UIThrStubs.c code into libX11 removes some
os-specific mess in config/cf/ and removes a library from the system that's not
used by anyone but libX11.

Attached is a patch for review that does the UIThrStubs.c move (which I would do
with a repocopy, if approved) and cleans up/fixes some threading imake defines
on BSDs.  Any feedback on this?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.