[Bug 1974] New: Xedit should work with '-xrm *international: false'

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Nov 30 15:13:52 PST 2004


Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
 
https://bugs.freedesktop.org/show_bug.cgi?id=1974        
   
           Summary: Xedit should work with '-xrm *international: false'
           Product: xorg
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: App/other
        AssignedTo: xorg-bugzilla-noise at freedesktop.org
        ReportedBy: pcpa at conectiva.com.br


I noticed that xorg's version of xedit changed code like:
...
XtVaCreateWidget("textSource", international ?
                 multiSrcObjectClass : asciiSrcObjectClass,
...
to
...
XtVaCreateWidget("textSource",
                 multiSrcObjectClass,
...

  I suggest to revert that change as Xedit.ad file has been
changed to add "*international: True".

  I didn't review everything, but this patch, after proper review,
should be applied:
--
--- commands.c.orig	2004-11-30 21:52:27.253693296 -0400
+++ commands.c	2004-11-30 21:53:15.448366592 -0400
@@ -357,8 +357,8 @@
 	      XtRemoveCallback(scratch, XtNcallback, SourceChanged,
 			       (XtPointer)item);
 	      item->source = scratch =
-		  XtVaCreateWidget("textSource",
-				   multiSrcObjectClass,
+		  XtVaCreateWidget("textSource", international ?
+				   multiSrcObjectClass : asciiSrcObjectClass,
 				   topwindow,
 				   XtNtype, XawAsciiFile,
 				   XtNeditType, XawtextEdit,
@@ -495,8 +495,8 @@
 	    XtSetArg(args[num_args], XtNstring, NULL); num_args++;
 	}
 
-	source = XtVaCreateWidget("textSource",
-				  multiSrcObjectClass,
+	source = XtVaCreateWidget("textSource", international ?
+				  multiSrcObjectClass : asciiSrcObjectClass,
 				  topwindow,
 				  XtNtype, XawAsciiFile,
 				  XtNeditType, XawtextEdit,
--- xedit.c.orig	2004-11-30 21:52:31.490049272 -0400
+++ xedit.c	2004-11-30 22:00:16.520353920 -0400
@@ -74,6 +74,7 @@
 Widget topwindow, textwindow, messwidget, labelwindow, filenamewindow;
 Widget scratch, hpane, vpanes[2], labels[3], texts[3], forms[3], positions[3];
 Widget options_popup, dirlabel, dirwindow;
+Boolean international;
 Boolean line_edit;
 XawTextWrapMode wrapmodes[3];
 
@@ -247,8 +248,9 @@
 		  flags = 0;
 		  XtSetArg(args[num_args], XtNstring, NULL);	num_args++;
 	      }
-	      source = XtVaCreateWidget("textSource",
-					multiSrcObjectClass, topwindow,
+	      source = XtVaCreateWidget("textSource", international ?
+					multiSrcObjectClass
+					: asciiSrcObjectClass, topwindow,
 					XtNtype, XawAsciiFile,
 					XtNeditType, XawtextEdit,
 					NULL, NULL);
@@ -356,10 +358,16 @@
     textwindow =  XtCreateManagedWidget(editWindow, asciiTextWidgetClass,
 					vpanes[0], arglist, num_args);
     num_args = 0;
+    XtSetArg(arglist[num_args], XtNinternational, &international);  
+    ++num_args;
+    XtGetValues(textwindow, arglist, num_args);
+
+    num_args = 0;
     XtSetArg(arglist[num_args], XtNtype, XawAsciiFile);			++num_args;
     XtSetArg(arglist[num_args], XtNeditType, XawtextEdit);		++num_args;
-    scratch = XtVaCreateWidget("textSource",
-			       multiSrcObjectClass, topwindow,
+    scratch = XtVaCreateWidget("textSource", international ?
+			       multiSrcObjectClass
+			       : asciiSrcObjectClass, topwindow,
 			       XtNtype, XawAsciiFile,
 			       XtNeditType, XawtextEdit,
 			       NULL, NULL);
--- xedit.h.orig	2004-09-02 04:40:32.000000000 -0400
+++ xedit.h	2004-11-30 21:55:59.211470816 -0400
@@ -100,6 +100,7 @@
 
 extern Widget topwindow, textwindow, labelwindow, filenamewindow, messwidget;
 extern Widget dirlabel, dirwindow;
+extern Boolean international;
 extern Boolean line_edit;
 
 /*	externals in xedit.c 	*/
--

  Today was the first time I run xorg...        
   
   
--         
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email       
   
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


More information about the xorg-bugzilla-noise mailing list