[xorg-bugzilla-noise] [Bug 1265] Render accel for tdfx

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
 
https://freedesktop.org/bugzilla/show_bug.cgi?id=1265        
   

anholt at FreeBSD.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anholt at FreeBSD.org




------- Additional Comments From anholt at FreeBSD.org  2004-09-09 12:29 -------
A few notes:
- Need to multiply source by alpha in your PictOpSrc case, since you haven't
premultiplied.
- Syncing needs to be done before writing anything with cpu to framebuffer, so
you appear to be correct.
- The DRI lock is taken by the server on wakeup and dropped on block, so your
driver doesn't need to worry about it.  Since you don't appear to rely on any
new set-once state, you don't need to worry about that either.  However, I don't
remember if tdfx had a set of flags in the shared area for sets of context
dirtied.  If so, just dumping 0xffffffff to it is probably the best idea.
- I'm concerned about the x8r8g8b8 format support, but I haven't read the code
thoroughly.  Remember that you have to treat the x bits as 1.  That means that
the XXX should be srcFormat comment appears correct.  But what about x8r8g8b8
src to a8r8g8b8 dest -- do the bits get filled with 1s?

        
   
   
--         
Configure bugmail: https://freedesktop.org/bugzilla/userprefs.cgi?tab=email       
   
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.