[Bug 2386] New: xrx does not build on Mac OS X

[bugzilla-daemon@freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to            
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=2386          
     
           Summary: xrx does not build on Mac OS X
           Product: xorg
           Version: 6.8.2
          Platform: Macintosh
        OS/Version: MacOS X
            Status: NEW
          Severity: blocker
          Priority: P2
         Component: App/other
        AssignedTo: xorg-bugzilla-noise@freedesktop.org
        ReportedBy: torrey@mrcla.com
                CC: roland.mainz@nrubsig.org


When building xrx from 6.8.2RC3 on Mac OS X one gets the error:

/usr/bin/cc -c -Os  -Wall -Wpointer-arith -no-cpp-precomp -fno-common  -I. -I../plugin -I../plugin/
include -I../rx   -I../../.. -I../../../exports/include   -D__powerpc__ -D__DARWIN__                                 
-DNO_ALLOCA -DCSRG_BASED      -DNETSCAPE_PLUGIN -DXP_UNIX -DNO_STARTING_STATE 
-DBSD44SOCKETS     -dynamic XnestDis.c
XnestDis.c: In function `IsDisplayNumFree':
XnestDis.c:57: error: storage size of `sbuf' isn't known
XnestDis.c:62: warning: implicit declaration of function `stat'
XnestDis.c:57: warning: unused variable `sbuf'
make: *** [XnestDis.o] Error 1

This is because the stat struct is defined in sys/stat.h, which is not pulled in. Adding the following 
patch fixes this and causes xrx to build correctly:

RCS file: /cvs/xorg/xc/programs/xrx/xnest-plugin/XnestDis.c,v
retrieving revision 1.2.4.1
diff -u -d -b -w -r1.2.4.1 XnestDis.c
--- XnestDis.c  24 Jan 2005 05:01:54 -0000      1.2.4.1
+++ XnestDis.c  27 Jan 2005 00:36:45 -0000
@@ -29,6 +29,7 @@
 /* $XFree86$ */
 
 #include "RxPlugin.h"
+#include <sys/stat.h>
 
 /***********************************************************************
  * Utility functions and global variable to manage display numbers

However, this is probably not platform independent. What is a good way to generalize this fix?          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.