[Bug 2408] New: XStringToKeysym return cannot possibly be correct

[bugzilla-daemon@freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to            
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=2408          
     
           Summary: XStringToKeysym return cannot possibly be correct
           Product: xorg
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Lib/Xlib
        AssignedTo: xorg-bugzilla-noise@freedesktop.org
        ReportedBy: daniel@freedesktop.org
                CC: Markus.Kuhn@cl.cam.ac.uk


>From XStringToKeysym (StrKeysym.c):
1.3          (kuhn     26-Sep-04):      if (val < 0x100)
1.3          (kuhn     26-Sep-04):          return val;
1.3          (kuhn     26-Sep-04):      if (val > 0x10ffff || val < 0x100)
1.2          (eich     23-Apr-04):          return NoSymbol;

I posit that, by virtue of defining < 0x100 to be a return of both val and
NoSymbol (though only the former ever gets reached, obviously), that this code
cannot possibly be correct in its current iteration.  Bradley, what's it
intended to be?          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.