[Bug 2749] New: Dynamic modules need visibility cleanups

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to    
       
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=2749          
     
           Summary: Dynamic modules need visibility cleanups
           Product: xorg
           Version: CVS_head
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: DDX/xorg
        AssignedTo: xorg-bugzilla-noise at freedesktop.org
        ReportedBy: ajax at nwnk.net


fb exports 330 symbols but has an effective public API of only 8.  exporting
just those 8 symbols reduces the object's size by 20k (about 10%) on x86.  the
function call entry for the other 322 symbols is shorter as a result, so
function calls get significantly cheaper.  i measured about a 6% speedup in
Render with render_bench with an early version of the attached patch.

fb will show the most performance improvement from this sort of cleanup, since
most other modules aren't CPU-intensive.  however the footprint reduction would
be similar across all modules.  excluding GLcore (which has its own set of
issues) this would drop runtime code footprint by about 160k on x86 assuming 10%
is typical.

this is potentially an ABI breaking change.

when i have solid performance numbers i'll post them here.          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.