proxymngr: Changes to 'master'
Alan Coopersmith
alanc at kemper.freedesktop.org
Sat Nov 8 16:09:30 PST 2014
config.c | 18 +++------
main.c | 44 ++++++++---------------
pmdb.c | 118 ++++++++++++++++++++++-----------------------------------------
pmint.h | 2 -
4 files changed, 66 insertions(+), 116 deletions(-)
New commits:
commit be8a5fbefcd6d3bee5e55283e06e255003b376b4
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Nov 8 16:05:52 2014 -0800
Stop checking if pointers are NULL before passing them to free()
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
commit f391fa1f55436ec2e4f7de4c4734fcd89cdbe250
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Nov 8 15:47:43 2014 -0800
Stop casting results of malloc calls
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
commit 5d5a7f80d905d58530c8473bc7ec0b0b3b165658
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Nov 8 15:45:00 2014 -0800
Replace last strcpy call + manual append with snprintf call
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
commit 9a17f21de44bcfe1493e9d10ae2354c2a3b496b1
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Nov 8 15:42:03 2014 -0800
Replace malloc(strlen)+strcpy sets with strdup calls
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
commit 333085a276a2bb2b156339cd9f8caa658ef4d1b6
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Nov 8 15:32:42 2014 -0800
Ensure memory is initialized before use in PushRequestorQueue
If authLen <= 0, then we weren't initializing the authName & authData
pointers until after checking if all the allocations succeeded, but
if any allocations failed, we'd then try to free them before that.
Error: Uninitialised memory (CWE 456)
Possible access to uninitialised memory '&newreq->authData'
at line 590 of pmdb.c in function 'PushRequestorQueue'.
&newreq->authData allocated at line 559.
&newreq->authData uninitialised when authLen <= 0 at line 568.
at line 591 of pmdb.c in function 'PushRequestorQueue'.
&newreq->authData allocated at line 559.
&newreq->authData uninitialised when authLen <= 0 at line 568
and newreq->authName == NULL at line 574.
Possible access to uninitialised memory '&newreq->authName'
at line 588 of pmdb.c in function 'PushRequestorQueue'.
&newreq->authName allocated at line 559.
&newreq->authName uninitialised when authLen <= 0 at line 568.
at line 589 of pmdb.c in function 'PushRequestorQueue'.
&newreq->authName allocated at line 559.
&newreq->authName uninitialised when authLen <= 0 at line 568
and newreq->authName != NULL at line 574.
[ This bug was found by the Parfait 1.5.1 bug checking tool.
http://labs.oracle.com/pls/apex/f?p=labs:49:::::P49_PROJECT_ID:13 ]
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
More information about the xorg-commit
mailing list