xserver: Branch 'master'

Adam Jackson ajax at kemper.freedesktop.org
Tue Jan 5 09:04:38 PST 2016


 include/list.h |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 792176417f7e62a99c4f07801f74f804d6080de2
Author: Adam Jackson <ajax at redhat.com>
Date:   Tue Jan 5 12:03:54 2016 -0500

    Revert "Fix uninitialized variable warnings reported by clang"
    
    Crashes at startup:
    
    dmt:~/git/xserver% ./hw/kdrive/ephyr/Xephyr :1
    (EE) Backtrace:
    (EE) 0: ./hw/kdrive/ephyr/Xephyr (OsSigHandler+0x29) [0x47c8f9]
    (EE) 1: /lib64/libc.so.6 (__restore_rt+0x0) [0x7f38d4de6b1f]
    (EE) 2: ./hw/kdrive/ephyr/Xephyr (InitNotifyFds+0x17) [0x478697]
    (EE) 3: ./hw/kdrive/ephyr/Xephyr (OsInit+0x1e) [0x47c99e]
    (EE) 4: ./hw/kdrive/ephyr/Xephyr (dix_main+0x11c) [0x446efc]
    (EE) 5: /lib64/libc.so.6 (__libc_start_main+0xf0) [0x7f38d4dd2580]
    (EE) 6: ./hw/kdrive/ephyr/Xephyr (_start+0x29) [0x427099]
    (EE) 7: ? (?+0x29) [0x29]
    (EE)
    (EE) Segmentation fault at address 0x0
    
    This reverts commit a221d4737c167589da44595c795d54f2c36b439a.

diff --git a/include/list.h b/include/list.h
index 1accf10..39f1985 100644
--- a/include/list.h
+++ b/include/list.h
@@ -304,8 +304,7 @@ xorg_list_is_empty(struct xorg_list *head)
  * @param member Member name of the struct xorg_list in the list elements.
  *
  */
-#define xorg_list_for_each_entry(pos, head, member)			\
-    pos = NULL;								\
+#define xorg_list_for_each_entry(pos, head, member)				\
     for (pos = __container_of((head)->next, pos, member);		\
 	 &pos->member != (head);					\
 	 pos = __container_of(pos->member.next, pos, member))
@@ -318,7 +317,6 @@ xorg_list_is_empty(struct xorg_list *head)
  * See xorg_list_for_each_entry for more details.
  */
 #define xorg_list_for_each_entry_safe(pos, tmp, head, member)		\
-    pos = NULL;								\
     for (pos = __container_of((head)->next, pos, member),		\
 	 tmp = __container_of(pos->member.next, pos, member);		\
 	 &pos->member != (head);					\


More information about the xorg-commit mailing list