libICE: Changes to 'master'
Emil Velikov
evelikov at kemper.freedesktop.org
Thu Sep 7 13:44:11 UTC 2017
configure.ac | 2 +
src/ICElibint.h | 4 +--
src/Makefile.am | 3 --
src/authutil.c | 21 +++++++++----------
src/connect.c | 8 ++-----
src/error.c | 8 +++----
src/getauth.c | 10 ++++-----
src/iceauth.c | 5 +---
src/icetrans.c | 4 ---
src/listen.c | 12 +++++------
src/listenwk.c | 2 -
src/misc.c | 18 ++++++++--------
src/process.c | 60 ++++++++++++++++++++++++++++++++------------------------
src/register.c | 2 -
src/replywait.c | 6 ++---
src/setauth.c | 2 -
src/shutdown.c | 8 +++----
src/watch.c | 6 ++---
18 files changed, 92 insertions(+), 89 deletions(-)
New commits:
commit 43644931cb9cb5cc92391f6f5431535b9b7a3f24
Author: Eric Engestrom <eric.engestrom at imgtec.com>
Date: Fri Jul 7 11:23:48 2017 +0100
Make sure string is never NULL
`error_message` is passed in to strncpy() without any check, which
doesn't handle NULL itself, so let's make it a valid empty string in
cases where it was NULL.
Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
Acked-by: Walter Harms <wharms at bfs.de>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
commit e8c21056134498c49733f6baf572ffbb051ed886
Author: Eric Engestrom <eric.engestrom at imgtec.com>
Date: Fri Jul 7 11:23:47 2017 +0100
Make sure error_message is a free-able string
Similar to the previous commit, assigning a static string would crash
upon freeing.
Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
Acked-by: Walter Harms <wharms at bfs.de>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
commit 7a7844bf5ade915268fe7f9b292908c6cd75f3ba
Author: Eric Engestrom <eric.engestrom at imgtec.com>
Date: Fri Jul 7 11:23:46 2017 +0100
Make sure errorStr is a free-able string
If the `errorClass` isn't handled by the switch, `errorStr`'s initial
value would be a pointer to some static memory with an empty string,
and freeing it would most likely crash.
Let's set it to NULL instead, as is done in other similar places.
Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
Acked-by: Walter Harms <wharms at bfs.de>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
commit 7ef9680caa8c223a09beb637e26fd3471128e6ba
Author: Emil Velikov <emil.l.velikov at gmail.com>
Date: Sun May 8 09:19:36 2016 +0100
configure.ac: set TRANS_CLIENT/SERVER
Similar to ICE_t just set the define globally and remove the multiple
definitions throughout the tree
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com> (IRC)
commit ab64a947b5de5b778f31ede9cfce386566023a14
Author: Emil Velikov <emil.l.velikov at gmail.com>
Date: Sun May 8 09:19:35 2016 +0100
Kill off local ICE_t definitions
Already defined at global scale in configure.ac
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com> (IRC)
commit f4c00d345edf3dad5893b50ff0ae7cd3e0cfd780
Author: Emil Velikov <emil.l.velikov at gmail.com>
Date: Sun May 8 09:19:34 2016 +0100
Remove unneeded ^L symbols.
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com> (IRC)
commit d603d7d7d989c4ff1094810e9fcf2a29bc00bb0c
Author: Emil Velikov <emil.l.velikov at gmail.com>
Date: Sun May 8 09:19:33 2016 +0100
Kill off Time_t macro
Analogous to previous commit, including the megacommit that removed the
need for it.
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com> (IRC)
commit 82250f26fc76d7b7574cfd472646a98e325d944a
Author: Emil Velikov <emil.l.velikov at gmail.com>
Date: Sun May 8 09:19:32 2016 +0100
Kill off Strstr macro
Directly use the strstr function as opposed to wrapping it in a macro.
The latter is no longer needed as of
commit 72e353567f8927996a26e72848d86f692c3f0737
Author: Kaleb Keithley <kaleb at freedesktop.org>
Date: Fri Nov 14 16:48:46 2003 +0000
XFree86 4.3.0.1
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com> (IRC)
More information about the xorg-commit
mailing list