[PATCH] xfree86: correctly define barriers for FreeBSD amd64

Benjamin Close Benjamin.Close at clearchain.com
Wed Apr 1 19:36:50 PDT 2009


Whilst I agree, I'm unable to test on other systems. I'm happy to add a 
comment
indicating it should be used but is untested.

On 27/02/2009 3:20 AM, Maarten Maathuis wrote:
> Perhaps this should be expanded to cover all amd64 systems?
>
> Maarten.
>
> On Thu, Feb 26, 2009 at 8:17 AM, Benjamin Close
> <Benjamin.Close at clearchain.com>  wrote:
>    
>> Previously when compiling on freebsd amd64 we'd end up at xi86
>> block (line 1315) which would define mem_barrier and write_mem_barrier
>> to be NOP's. Instead they should be valid, as per the linux amd64 setup.
>>
>> This stops the hangs experienced by many when using the nv driver
>> which would hang due to out of order dma requests as noticed in
>> http://bugs.freedesktop.org/show_bug.cgi?id=3168
>>
>> Signed-off-by: Benjamin Close<Benjamin.Close at clearchain.com>
>> ---
>>   hw/xfree86/common/compiler.h |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/xfree86/common/compiler.h b/hw/xfree86/common/compiler.h
>> index 2601693..afb44ad 100644
>> --- a/hw/xfree86/common/compiler.h
>> +++ b/hw/xfree86/common/compiler.h
>> @@ -461,7 +461,7 @@ extern _X_EXPORT unsigned int inb(unsigned long port);
>>   extern _X_EXPORT unsigned int inw(unsigned long port);
>>   extern _X_EXPORT unsigned int inl(unsigned long port);
>>
>> -#   elif defined(linux)&&  defined(__amd64__)
>> +#   elif (defined(linux) || defined(__FreeBSD__))&&  defined(__amd64__)
>>
>>   #    include<inttypes.h>
>>
>> --
>> 1.6.0.2
>>
>> _______________________________________________
>> xorg-devel mailing list
>> xorg-devel at lists.x.org
>> http://lists.x.org/mailman/listinfo/xorg-devel
>>
>>      



More information about the xorg-devel mailing list