EXA EnableDisableFBAccess paths.

Dave Airlie airlied at redhat.com
Thu Apr 16 01:31:47 PDT 2009


On Thu, 2009-04-16 at 10:21 +0200, Michel Dänzer wrote:
> On Thu, 2009-04-16 at 11:03 +1000, Dave Airlie wrote:
> > I think we have a problem with the EnableDisableFBAccess paths,
> > but I'm not 100% sure how to fix it. However I don't believe the
> > swapped out flag should be hit for driver pixmaps at all.
> > 
> > The problem is on VT enter, the wrapped EDFBA function, does an 
> > if (set_disable) disable, call wrap, if (set_enabled) enable, however inside
> > the call wrap we get an exposure generation and we end up doing a bunch
> > of pointless sw rendering when clearly we could avoid it.
> > 
> > But I'm not sure what the logic behind the wrap calling sequence.
> 
> The logic you're referring to isn't in exaEnableDisableFBAccess(), is
> it?

No its the examodule.c in the xfree86 module.

Dave.

> 
> > I've attached a patch that avoids hitting swapped out flag for driver pixmaps
> > and this makes fast user switch on radeon/kms actually fast.
> 
> Makes sense, the swappedOut flag really only applies to the EXA
> offscreen allocator.
> 
> 



More information about the xorg-devel mailing list