[PATCH 1/2] mi: fix cursor warping screens

Vignatti Tiago (Nokia-D/Helsinki) tiago.vignatti at nokia.com
Sat Aug 8 10:10:39 PDT 2009


On Fri, Aug 07, 2009 at 01:58:41AM +0200, Peter Hutterer wrote:
> How about the patch attached. It ends up being the same logic but the code
> looks nicer (even though the patch doesn't). Instead of the fallthrough into
> the default statement, the default block is moved out of the switch.

coolio! Worked fine here. I'll apply.


> This leaves one remaining issue though. Previously, the code would not
> process motion events if a screen switch takes place. I've already explained
> why we can't drop button and key events but - should we still drop motion
> events?
> i.e. do we need a if (type == motion) return; after the NewCurrentScreen?

For me it just make sense to let the server continue the normal processing and
deliver the motion event to some eventual client. So I would not put this
return there.


Cheers,

            Tiago


More information about the xorg-devel mailing list