[PATCH] xfree86: Remove xf86GetMotionEvents from public API.

[Peter Hutterer]

On Tue, Aug 25, 2009 at 05:12:18PM +0300, Tiago Vignatti wrote:
> On Mon, Aug 24, 2009 at 06:58:15AM +0200, ext Peter Hutterer wrote:
> > This function was used as the default motion event queue API to set up a
> > device in the input driver init process until including XINPUT_ABI 2 (server
> > 1.5). This API was broken with 1883485 in May 2008 (wrong casting of
> > parameters) nobody seems to have noticed. Mainly because it's not in use by
> > input drivers past ABI 3.  
> > 
> > Motion history is handled in the DIX now.
> > 
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> 
> 
> It's running ok here. Though I can see lot of cases of this function being
> called on "non upstream" input drivers.

I checked linuxwacom - possibly the most popular out-of-stream driver. It
used it in the same way as others, i.e. only as a parameter to
InitValuatorClassDeviceStruct.

Other drivers - not sure but they probably should have complained by now
that it's broken.

Cheers,
  Peter

> > ---
> >  hw/xfree86/common/xf86Helper.c |    7 -------
> >  hw/xfree86/common/xf86Xinput.h |    3 ---
> >  2 files changed, 0 insertions(+), 10 deletions(-)
> > 
> > diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
> > index f70b4e8..9a2468d 100644
> > --- a/hw/xfree86/common/xf86Helper.c
> > +++ b/hw/xfree86/common/xf86Helper.c
> > @@ -2586,10 +2586,3 @@ xf86MotionHistoryAllocate(LocalDevicePtr local)
> >  {
> >      AllocateMotionHistory(local->dev);
> >  }
> > -
> > -int
> > -xf86GetMotionEvents(DeviceIntPtr pDev, xTimecoord *buff, unsigned long start,
> > -                    unsigned long stop, ScreenPtr pScreen, BOOL core)
> > -{
> > -    return GetMotionHistory(pDev, buff, start, stop, pScreen, core);
> > -}
> > diff --git a/hw/xfree86/common/xf86Xinput.h b/hw/xfree86/common/xf86Xinput.h
> > index b1b88ac..aa9e9d5 100644
> > --- a/hw/xfree86/common/xf86Xinput.h
> > +++ b/hw/xfree86/common/xf86Xinput.h
> > @@ -206,9 +206,6 @@ extern _X_EXPORT InputDriverPtr xf86LookupInputDriver(const char *name);
> >  extern _X_EXPORT InputInfoPtr xf86LookupInput(const char *name);
> >  extern _X_EXPORT void xf86DeleteInput(InputInfoPtr pInp, int flags);
> >  extern _X_EXPORT void xf86MotionHistoryAllocate(LocalDevicePtr local);
> > -extern _X_EXPORT int xf86GetMotionEvents(DeviceIntPtr dev, xTimecoord *buff,
> > -                        unsigned long start, unsigned long stop,
> > -                        ScreenPtr pScreen, BOOL core);
> >  
> >  /* xf86Option.c */
> >  extern _X_EXPORT void xf86CollectInputOptions(InputInfoPtr pInfo, const char **defaultOpts,
> > -- 
> > 1.6.3.rc1.2.g0164.dirty
> > 
> > _______________________________________________
> > xorg-devel mailing list
> > xorg-devel at lists.x.org
> > http://lists.x.org/mailman/listinfo/xorg-devel
>             Tiago