[PATCH] xfree86: tell users to disable AutoAddDevices, not AllowEmptyInput.

James Cloos cloos at jhcloos.com
Wed Dec 2 03:26:05 PST 2009


>>>>> "Peter" == Peter Hutterer <peter.hutterer at who-t.net> writes:

Peter> Technically, disabling AEI is the right suggestion. AEI off forces the
Peter> server to init the built-in defaults for input devices (or pick the first
Peter> one from the config file). At the same time, hotplugging is still available
Peter> with AEI off.

Peter> Unfortunatly, in the vast majority of cases users want to simply disable
Peter> hotplugging or have a working server while the local HAL configuration is
Peter> broken or missing. Disabling AEI will lead to duplicate events, triple
Peter> keystrokes, etc. once the configuration works again.
Peter> It's not actually required to remove AEI once hotplugging works again,
Peter> though it will in many cases lead to a setup that appears broken.

Peter> Asking users to disable AutoAddDevices instead means those users disable
Peter> hotplugging, can then fix the HAL setup and they _must_ remove the config
Peter> line again to test if hotplugging works again. Which doesn't leave them with
Peter> a broken config once everything is working nice and dandy. Less bugreports,
Peter> everybody wins.

Peter> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Your reasoning is sound.

Signed-off-by: James Cloos <cloos at jhcloos.com>

-JimC
-- 
James Cloos <cloos at jhcloos.com>         OpenPGP: 1024D/ED7DAEA6


More information about the xorg-devel mailing list