[PATCH] EXA: Use correct coordinate system for calculating Composite fallback region.

[Keith Packard]

On Wed,  2 Dec 2009 11:48:11 +0100, Michel Dänzer <michel at daenzer.net> wrote:

> +	if (pSrc->pDrawable) {
> +	    xSrc += pSrc->pDrawable->x;
> +	    ySrc += pSrc->pDrawable->y;
> +	}
> +
> +	if (pMask && pMask->pDrawable) {
> +	    xMask += pMask->pDrawable->x;
> +	    yMask += pMask->pDrawable->y;
> +	}
> +

I haven't read through the code carefully yet, but if there are
transforms involved, then this computation is incorrect -- source
coordinates are in the post-transform space. Given that the next line
calls miComputeCompositeRegion, that would also be incorrect in the
presence of source or mask transforms (yay!).

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091202/3c3ecce8/attachment.pgp