[PATCH] EXA/mixed: Don't consider devKind for detecting dimension change.

[Keith Packard]

On Thu, 10 Dec 2009 00:04:53 +0100, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <daenzer at vmware.com>
> 
> Fixes http://bugs.freedesktop.org/show_bug.cgi?id=25536 .
> 
> There should be no reason for the pitch to actually change when none of the
> other dimensions do, and this could lead to incorrectly freeing the system
> memory copy when allocating a GPU copy, resulting in loss of valid pixmap
> contents.

One can imagine the driver wanting to change padding requirements to hit
some different tiling mode; is this not a reasonable thing to account
for?

And, of course, why would someone send a devKind that wasn't the same
without intending to change it? Sure seems like you're masking a bug in
other code.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091209/66857ec4/attachment.pgp