[PATCH v4 1/3] xfree86: Unexport configuration file symbols

[Peter Hutterer]

On Mon, Dec 21, 2009 at 12:35:07PM -0800, Dan Nicholson wrote:
> These functions should not be used outside of DDXs, so no need to put
> them in the ABI.
> 
> Signed-off-by: Dan Nicholson <dbn.lists at gmail.com>
> ---
>  hw/xfree86/parser/xf86Parser.h |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/xfree86/parser/xf86Parser.h b/hw/xfree86/parser/xf86Parser.h
> index 6030800..efa1b85 100644
> --- a/hw/xfree86/parser/xf86Parser.h
> +++ b/hw/xfree86/parser/xf86Parser.h
> @@ -456,13 +456,13 @@ xf86ConfigSymTabRec, *xf86ConfigSymTabPtr;
>  /*
>   * prototypes for public functions
>   */
> -extern _X_EXPORT const char *xf86openConfigFile (const char *, const char *,
> -					const char *);
> -extern _X_EXPORT void xf86setBuiltinConfig(const char *config[]);
> -extern _X_EXPORT XF86ConfigPtr xf86readConfigFile (void);
> -extern _X_EXPORT void xf86closeConfigFile (void);
> -extern _X_EXPORT void xf86freeConfig (XF86ConfigPtr p);
> -extern _X_EXPORT int xf86writeConfigFile (const char *, XF86ConfigPtr);
> +extern const char *xf86openConfigFile(const char *, const char *,
> +				      const char *);
> +extern void xf86setBuiltinConfig(const char *config[]);
> +extern XF86ConfigPtr xf86readConfigFile(void);
> +extern void xf86closeConfigFile(void);
> +extern void xf86freeConfig(XF86ConfigPtr p);
> +extern int xf86writeConfigFile(const char *, XF86ConfigPtr);
>  extern _X_EXPORT XF86ConfDevicePtr xf86findDevice(const char *ident, XF86ConfDevicePtr p);
>  extern _X_EXPORT XF86ConfLayoutPtr xf86findLayout(const char *name, XF86ConfLayoutPtr list);
>  extern _X_EXPORT XF86ConfMonitorPtr xf86findMonitor(const char *ident, XF86ConfMonitorPtr p);
> -- 
> 1.6.2.5

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

fwiw, the xf86findDevice and friends are not to be exported either AIUI.

Cheers,
  Peter