[PATCH] [1.7] fb: backport fb changes from master for src window operations.

[Aaron Plattner]

On Tue, Dec 22, 2009 at 08:38:21PM -0800, Peter Hutterer wrote:
> On Mon, Dec 21, 2009 at 12:38:23PM +1000, Dave Airlie wrote:
> > On Sun, 2009-12-20 at 18:35 -0800, Keith Packard wrote:
> > > On Mon, 21 Dec 2009 12:26:26 +1000, Dave Airlie <airlied at redhat.com> wrote:
> > > > This rolls up the following commits and also keeps the image_from_pict
> > > > API compatiblity. It introduces a new image_from_pict_18 API that is
> > > > used by the server leaving the old API alone.
> > > > 
> > > > I've rolled this up as I don't want to introduce ABI breaks in
> > > > bisection.
> > > 
> > > This doesn't preserve the behaviour of the 1.7 image_from_pict; any
> > > operation fetching from a window will now get data relative to the
> > > underlying pixmap origin rather than the window origin within that
> > > pixmap.
> > > 
> > 
> > I think we've already busted the 1.7 image_from_pict behaviour,
> > then we fixed up the API to make it look nice without restoring the
> > behaviour, this just fixes up the internals with the API, and leave
> > the image_from_pict API as busted as 1.7.3 has it.
> > 
> > So I'm not sure what Aaron prefers here, since he seemed happy
> > with the 1.7.3 behaviour which I haven't changed.
> 
> I've pushed this to the 1.7 nominations branch to get some testing (in
> theory anyway). We can always revert it. Aaron - waiting for your ACK/NAK on
> this patch. As it is I'll change the 1.7.4 schedule until we've had at least
> once RC that includes the final verdict on this patch.

Honestly, I don't care as long as the huge performance regression is fixed.

-- Aaron