[PATCH] xserver: Avoid sending uninitialized padding data over the network

Peter Åstrand astrand at cendio.se
Wed Feb 11 23:38:22 PST 2009


> Thanks for the patch.
> There's a nitpick and it's arguably personal preference: please shift the
> memsets for reply handling down to happen before, well, the reply handling.
> Take the example of the GetModifierMapping handling:

Thanks for the feedback. There were two main reasons why I added the 
memset directly after the variables section:

1) It's easier to see that the memset exists and uses the correct type. 
For example, in most patch "chunks", both the variable declaration and the 
memset is visible.

2) In some cases, a single variable is used in several code paths.

Anyway, if the consensus is that the memset should be moved further down, 
I can probably fix such a patch.


Regards, 
---
Peter Åstrand		ThinLinc Chief Developer
Cendio AB		http://www.cendio.com
Wallenbergs gata 4
583 30 Linköping	Phone: +46-13-21 46 00


More information about the xorg-devel mailing list