[PATCH 09/10] xf86-input-acecad: Simplify value of $sdkdir.

[Dan Nicholson]

On Fri, Feb 13, 2009 at 1:07 PM, Paulo César Pereira de Andrade
<pcpa at mandriva.com.br> wrote:
> Dan Nicholson wrote:
>
>>>>>  When setting the variable value using `pkg-config --variable`
>>>>> it causes make distcheck to fail, and needing to circunvent the
>>>>> problem by adding a configure option.
>>>>
>>>> If you want to make this change, then do it in the other drivers, too.
>>>
>>>  That's why this patch was a "proposed pattern" for changes in
>>> other packages. (But I am posting only this one, don't be afraid
>>> of having 1k patches in your inbox by tomorrow :-))
>>
>> But it's buried in the middle of a set of acecad janitor patches. I
>> also wasn't implying that you should post patches for every driver
>> yet. What I meant was to send an email describing how you want to
>
>  This was somewhat of an "evolutive" approach.
> o First were the patches adding things like --with-sdkdir=<pathname>,
>  that would fix the "make distcheck" issue.
> o After it was (what I also first suggested for "hardcoding"
>  --app-defaults-dir) to assume none wants to modify the "sufix"
>  of a pathname, so $includedir/xorg would be safe, as none
>  should want to use $includedir/<othername>.
> o And now it is an even "untested" :-) change to modify
>  xorg-server.m4, add version check to it, and extra macros, for
>  these issues.
>
>  xorg-server.pc sets:
> prefix=/usr/local
> exec_prefix=${prefix}
> libdir=${exec_prefix}/lib
> includedir=${prefix}/include
> moduledir=${exec_prefix}/lib/xorg/modules
> sdkdir=${prefix}/include/xorg
>
>  Maybe there could be a way to have more "friendly" integration of
> automake and pkg-config, but in the sample macro for xorg-server.m4
> I suggested in the previous email, it would "just" be required to
> have it match xorg-server.pc for moduledir and sdkdir.

Yeah, that seems fine. I think the macro as you've described it would
be fine. Or using sdkdir='${includedir}/xorg' and
moduledir='${libdir}/xorg/modules' directly in the driver's configure
would be fine, too. I was just hoping that you would send a mail
discussing just that change, rather than in a series of other patches.

But I'm making a much bigger deal out of this than it needs to be. Sorry.

>> change the drivers to just install to $includedir/xorg and
>> $libdir/xorg/modules instead of whatever they're doing now. Then, if
>> no one has any issues with that, you can just push 50 patches.
>
>  You can consider this patch just a last attempt to help :-)
> I cannot push patches anymore anyway. Given that I did not
> have much success on working more closely with xorg people, I
> am just unsubscribing from xorg mailing lists.

I don't think it's necessary to unsubscribe, and I hope you can push
patches again soon. I didn't realize that hadn't happened yet. I'm no
more of an xorg person than you are. I just got frustrated because
we've had this same conversation several times.

--
Dan