[PATCH v2] xkb: Use cached XKB keymap when rules haven't changed

Dan Nicholson dbn.lists at gmail.com
Wed Feb 18 23:19:38 PST 2009


On Wed, Feb 18, 2009 at 9:33 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> On Tue, Feb 17, 2009 at 10:46:05PM -0800, Dan Nicholson wrote:
>> Rather than compiling a new keymap every time InitKeyboardDeviceStruct
>> is called, cache the previous keymap and reuse it if the rules have not
>> changed.
>>
>> Signed-off-by: Dan Nicholson <dbn.lists at gmail.com>
>> ---
>>  The RMLVO comparison takes into account empty string vs. NULL. Should
>>  it do that? I can't tell from a cursory glance through xkb/maprule.c
>>  whether that's important or not.
>
>
> 15:25 < whot> daniels: is the NULL != "" thing an issue? it not, I'll push,
> the patch works
> 15:26 < daniels> NULL and "" should be treated identically
>
> Other than that, ACK from me.

Thanks for the clarification. I'll clean it up and resend.

--
Dan


More information about the xorg-devel mailing list