[PATCH] xserver: Unclaim PCI slot if driver probing fails.

Matthias Hopf mhopf at suse.de
Thu Jul 2 06:16:35 PDT 2009


On Jul 02, 09 15:00:54 +0300, Tiago Vignatti wrote:
> On Wed, Jul 01, 2009 at 03:38:41PM +0200, ext Matthias Hopf wrote:
> > This patch unclaims a pci slot by setting its bus type to BUS_NONE, so
> > it doesn't match any more. I don't remove the allocation slot at the
> > moment, because I'm unsure that there are no references left (and this
> > is unlikely to be a regularly called function).
> Sounds a good temporally approach. On the other hand, ideally we should not
> stack anything else in that ridiculous device initialization code there. It's
> getting worse with the time.

That's the main reason I didn't deallocate the entry but only disabled
it - the code is really fragile.

Thanks

Matthias

-- 
Matthias Hopf <mhopf at suse.de>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat at mshopf.de
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de


More information about the xorg-devel mailing list