Road to pixman 0.16.0

[Edward O'Callaghan]

Hi,

Just wanted to give me input on the choice of code style. That is, I
believe you should use if (..) {  instead, for two reason right off
the top of my head.

A.) Does not pointless waste screen real estate; Allowing someone to
see more of the code block at once, instead of scrolling all the time.
B.) Its clear that there is indeed a '{' following that if statement
and its indeed clear that this '{' is part of that if statement.

Any way, you may or may not agree however this is my two cent.

Thanks for listening,
Edward.

2009/7/14 Soeren Sandmann <sandmann at daimi.au.dk>:
> Hi,
>
> Pixman 0.15.16 contains the last bits of refactoring, so from now on,
> there will be a coding style enforced. The coding style is similar to
> cairo's, with the main difference being that braces go on their own
> line always. Ie.,
>
>        if (...)
>        {
>        }
>
> and not
>
>        if (...) {
>        }
>
> The cairo coding style document is here:
>
>        http://cgit.freedesktop.org/cairo/tree/CODING_STYLE
>
> Here is a rough road map for the remaining things before 0.16.0:
>
> * Disable region self-check
>
> * MSVC fixes.
>
>   - The Makefile.win32 broke as Rainman Lee pointed out.
>
>   - There is this bug:
>
>       https://bugs.freedesktop.org/show_bug.cgi?id=22390
>
>     with fixes for sse2 on x64. The mmx file there seems sane to me,
>     but it would be good if someone with access to Windows can verify
>     that it work.
>
>  Someone with access to this compiler, please help out if you can.
>
> * ARM fixes
>
>  - The current code is not releasable.
>
>    Unless I hear otherwise, I'll just apply Siarhei's fixes after
>    they are updated for code style issues.
>
>  - Build fixes for older CPUs:
>
>        https://bugs.freedesktop.org/show_bug.cgi?id=22692
>
>    Siarhei says it's reasonable, so unless I hear otherwise, I'll
>    apply that as well.
>
> * Merge the blitter-test code.
>
>  - Some changes are needed; see other mail.
>
> * Fix bugs reported by the blitter-test
>
>  - The discrepancies between the architecture specific code and the
>    general C code should be tracked down and fixed.
>
>  - It should be tracked down why enabling component-alpha causes
>    crashes.
>
> * Fix performance regressions.
>
>  There have been reports of performance regressions. The ones I am
>  aware of are:
>
>  - Image allocation may have become slower
>
>  - _pixman_run_fast_path() may have too much overhead
>
>  - Delegates may have too much overhead
>
>  - Carl reported that the swfdec-fill-rate-2xaa perf-trace had a 25%
>    performance regression between 0.15.1 and 0.15.13
>
> Let me know if I missed anything.
>
> There will be at least one, and probably two, development releases
> before 0.16.0. I'll be spending a bit less time on pixman in the
> coming weeks, so help is appreciated with the above items.
>
>
> Thanks,
> Soren
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel
>



-- 
-- 
Edward O'Callaghan
http://www.auroraux.org/
eocallaghan at auroraux dot org