[PATCH] include: untangle events.h from the SDK headers.

Peter Hutterer peter.hutterer at who-t.net
Tue Jul 28 20:49:21 PDT 2009


On Tue, Jul 28, 2009 at 08:11:35PM -0700, Aaron Plattner wrote:
> Seems fine to me.
> 
> This was in the original events.h already, but doesn't
> 
>         enum {
>           ET_KeyPress = 2,
>           [...]
>           ET_Internal = 0xFF /* First byte */
>         } EventType;
>         
> declare a global variable named EventType?

oops. yes. sorry, patch below.

>         
>         $ nm hw/xfree86/Xorg | grep EventType
>         00000000007d4ea8 b EventType
> 
> While we're at it, why does DeviceEvent use int plus a comment instead
> of EventType for the "type" field?

Patch below as well, a bit noisy thanks to the required default cases.
Thanks for the review.




More information about the xorg-devel mailing list