[PATCH 1/3] Standartize on C99 inline
Tomas Carnecky
tom at dbservice.com
Sat Mar 21 00:33:49 PDT 2009
On Mar 20, 2009, at 7:03 PM, Dan Nicholson wrote:
> On Fri, Mar 20, 2009 at 10:36 AM, Tomas Carnecky <tom at dbservice.com>
> wrote:
>>
>> diff --git a/configure.ac b/configure.ac
>> index f4e1dbb..f02292f 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -109,6 +109,7 @@ AC_CHECK_HEADERS([fcntl.h stdlib.h string.h
>> unistd.h])
>>
>> dnl Checks for typedefs, structures, and compiler characteristics.
>> AC_C_CONST
>> +AC_C_INLINE
>> AC_C_BIGENDIAN([ENDIAN="X_BIG_ENDIAN"], [ENDIAN="X_LITTLE_ENDIAN"])
>
> You could do this check once in xproto and define _X_INLINE
> appropriately. Then all X users could take advantage of it.
FWIW, Xfuncproto.h already contains preprocessor directives that check
for inline support (based on compiler type/version) and sets _X_INLINE
appropriately.
I was just trying to clean up the different inline keywords. I asked
on IRC and Alan responded that it's ok to settle on C99 inline. I
don't think that's an unreasonable requirement, given that we already
require other C99 extensions (named initializers, variadic macros etc).
tom
More information about the xorg-devel
mailing list