[PATCH] Lift fatal signal handlers from DDX'es up to a common DIX implementation

Alan Coopersmith Alan.Coopersmith at Sun.COM
Tue Mar 31 17:38:01 PDT 2009


Peter Hutterer wrote:
>>  void
>>  AbortServer(void)
>>  {
>> +#ifdef XF86BIGFONT
>> +    XF86BigfontCleanup();
>> +#endif
> 
>>      CloseWellKnownConnections();
>>      OsCleanup(TRUE);
>>      CloseDownDevices();
> 
> Not sure about this hunk. I thought the "rule" is that no XF86 code should be
> in the dix. Can these three lines be moved into the xf86SigHandler?

XF86BigFont isn't from the xf86 DDX layer, but is a DIX layer extension added
by XFree86 (Xext/xf86bigfont.c), so is already an exception to that rule.
There's calls to it in dix/dixfonts.c & mi/miinitext.c as well.

In the normal exit path, XF86BigfontCleanup() is called from
CloseDownExtensions(), which might be a cleaner way to get all
the extensions like MIT-SHM & XF86Bigfont that need to release
shared memory segments and other persistent resources to do so,
though I haven't checked to see what all the extensions do in
their ResetProc handlers.

-- 
	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering



More information about the xorg-devel mailing list