[PATCH] xkb: Don't press+release keys on key events

Matthias Hopf mhopf at suse.de
Wed May 20 05:46:17 PDT 2009


Some users get F7 delivered to apps when switching from console to X.
After some debugging I found the culprit, but am unsure whether I'm
doing something stupid with this patch.

Given the popularity of the xkb layer probably only few can comment here.
Daniel? Peter?

IMHO the key repeat logic is broken here, Press+Release events should
only be committed if the key state is down, not for up AND down.
I verified that key repeat is still working, and so far I couldn't find
any side effects - but of course I don't have all keyboard layouts and
special hardware and architectures.

I'm on vacation next week, and will commit this patch afterwards if
nobody objects.

Matthias

-- 
Matthias Hopf <mhopf at suse.de>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat at mshopf.de
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xkb-Don-t-press-release-keys-on-key-events.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090520/0b1b9e60/attachment.bin 


More information about the xorg-devel mailing list