[PATCH] Abstract calls to in/out with IN/OUT macros
mattst88 at gmail.com
Sun Nov 1 15:22:39 PST 2009
On Sun, Nov 1, 2009 at 6:13 PM, keithp <keithp at keithp.com> wrote:
> Excerpts from Mark Kettenis's message of Sun Nov 01 13:19:04 -0800 2009:
>> While I sympathise with your attempt to clean up the mess in
>> compiler.h, this will break at least one driver (xf86-video-i128).
> A fine example of why we want to merge the drivers into the server :-)
> In any case, for now, I'd rather see an ABI/API compatible change that
> has the server get at the system io functions through a standard api
> while still providing the old interfaces so that drivers continue to
> build unchanged. Having those old interfaces work through the new
> standard API would be great if possible. Marking those as 'deprecated'
> so that the compiler emits a warning would be a nice bonus.
This would be nice, but I'm not sure how it could be possible, since
in half the cases of OS/Architecture combinations, the drivers call
the libc in/out, so no chance to warn. Then again, this is entirely
the problem with the current 'API' if we can even call it that.
If you've got ideas, I'm all ears.
I don't see any problem with minorly breaking the API (fixable by
trivial search-replace patches) to give it some kind of sanity.
Anyway, I mailed a patch, but it was too large for xorg-devel. I guess
you received it already, Keith?
More information about the xorg-devel