[PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

Maarten Maathuis madman2003 at gmail.com
Mon Nov 9 10:52:05 PST 2009

On Mon, Nov 9, 2009 at 12:14 AM, Maarten Maathuis <madman2003 at gmail.com> wrote:
>> This is just an observation, but I do find the fact we have two things
>> exaPixmapIsOffscreen(pPixmap)
>> and
>> !pExaPixmap->offscreen
>> Like I know they are different but really seriously can anyone know
>> the difference just by reading this?
>> EXA has become quite complicated recently and very difficult to trace
>> through, this naming doesn't help.
>> Dave.
> I understand your concern and i appreciate you bringing this up. I
> will get back to you as soon as i have some decent ideas.
> Maarten.

exaPixmapIsOffscreen() is related to having a driver/vram/whatever pixmap

pExaPixmap->offscreen says if the offscreen pixmap is the current
choice of rendering to

The naming came from classic exa. Some better names might be:

exaPixmapHasOffscreen() and pExaPixmap->using_offscreen/use_offscreen

What do people think?


More information about the xorg-devel mailing list