[PATCH 2/5] xserver: Makefile.am: do not include autogen.sh in distribution #24183

Gaetan Nadon gaetan.nadon at videotron.ca
Tue Nov 10 09:05:37 PST 2009

As described in the INSTALL file, "Briefly, the shell commands

make; make install' should configure, build, and install this package".

In Makefile.am, the AM_MAINTAINER_MODE macro disables by default the maintainer
build rules. If Makefile.am is changed, the make program will not reconfigure
the component. Otherwise the package would be reconfigure with different or
missing Autotools and could break, making it difficult for anyone to debug.

When the component is built using build.sh or tinderbox, autogen.sh is used
which passes the --enable-maintainer-mode option to ./configure. This allows
the maintainer to make changes to the configuration and get an automatic
rebuild when necessary. 

By shipping autogen.sh we are introducing another build entry point which isn't
documented and is confusing. The behavior will also be different as it enables
the maintainer build rules.

 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index a5e0730..3aa1fb4 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -49,7 +49,7 @@ pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = xorg-server.pc
-EXTRA_DIST = xorg-server.pc.in xorg-server.m4 ChangeLog autogen.sh
+EXTRA_DIST = xorg-server.pc.in xorg-server.m4 ChangeLog
 	--with-xkb-path=$(XKB_BASE_DIRECTORY) \

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20091110/3d69f825/attachment.html 

More information about the xorg-devel mailing list