[PATCH 2/2] I/O port access routines
daniel at fooishbar.org
Wed Nov 18 16:21:40 PST 2009
On Thu, Nov 19, 2009 at 12:37:10AM +0100, Luc Verhaegen wrote:
> So how would we go about using any of this then? Do we get to have
> another huge API/ABI breakage like when libpciaccess was introduced just
> because the normal in/out routines should no longer be used?
It's not even an ABI break, let alone API. If you read the patch,
you'll note that new calls are being added, and nothing modified;
drivers which choose to make use of these calls can make use of them.
If you want to be compatible back to 6.9, you can ifdef it, or make a
wrapper if you really care that much.
> Oh, and that's before i start wondering about gratuitous void pointers
> and goto.
There's absolutely nothing wrong with void pointers (what do you
recommend instead?), and goto is used in one place, as an error path to
unwind, which is a very common coding practice (cf. the kernel) which
avoids an entire class of errors related to failing to free things on
an error return, mainly because you have the same unwind code duplicated
in 17 different places.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091119/0be7abd9/attachment.pgp
More information about the xorg-devel