[PATCH] Bug #25136: Fix a severe performance regression caused by fb reading back the screen.
aplattner at nvidia.com
Wed Nov 18 20:52:43 PST 2009
On Wed, Nov 18, 2009 at 07:46:38PM -0800, Keith Packard wrote:
> On Wed, 18 Nov 2009 18:53:18 -0800, Aaron Plattner <aplattner at nvidia.com> wrote:
> > Commit e9aa61e9f0d663d5b34a397b943b4d1df44e873d added code to copy the
> > source
> Why would we have to *copy* the source if it happens to be a window? I
> mean, we have to clip to some pixmap eventually, so why don't we just
> clip to the pixmap the bits are currently in instead of creating a whole
> new pixmap to clip to? Some explanation seems indicated here to justify
> the original hack.
> Yes, Aaron, your fix looks reasonable (when combined with the other
> un-pushed Fedora patch). But, I'd rather fix the original problem
> instead of applying a band-aid.
Agreed, but can we please apply these band-aids or revert e9aa61e in
server-1.7-branch and fix it better in master?
More information about the xorg-devel