[PATCH 2/2] I/O port access routines

Tiago Vignatti tiago.vignatti at nokia.com
Thu Nov 19 10:34:47 PST 2009


On Thu, Nov 19, 2009 at 06:36:12PM +0100, Luc Verhaegen wrote:
> 
> And Tiago, it was not coupled that tightly.

Well, just look at the head of xf86pciBus.c (before RAC be removed and when the
old PCI code was in place):


#ifdef HAVE_XORG_CONFIG_H
#include <xorg-config.h>
#endif

#include <ctype.h>
#include <stdlib.h>
#include <unistd.h>
#include <X11/X.h>
#include "os.h"
#include "Pci.h"
#include "xf86.h"
#include "xf86Priv.h"
#include "xf86Resources.h"

/* Bus-specific headers */
#include "xf86PciData.h"

#include "xf86Bus.h"

#define XF86_OS_PRIVS
#define NEED_OS_RAC_PROTOS
#include "xf86_OSproc.h"

#include "xf86RAC.h"


It was mix of RAC + PCI + BUS + high level screen informations + X protocol +
real-mode things and etc, and you're saying that that code was not coupled? 

So I _really_ don't know what you mean about tightly, coupled and confusing
code...

            Tiago


More information about the xorg-devel mailing list