[PATCH] Bug #25136: Revert "Fix clipping when windows are used as sources"

Peter Hutterer peter.hutterer at who-t.net
Wed Nov 25 21:49:38 PST 2009


On Tue, Nov 24, 2009 at 10:21:28AM -0800, Aaron Plattner wrote:
> That change causes lib(w)fb to make accelerated driver calls after the driver
> has entered a software fallback.  Most drivers don't expect this, which leads to
> corruption or crashes.  A change to make this code do the copy in software is
> unacceptably slow.
> 
> This reverts commit e9aa61e9f0d663d5b34a397b943b4d1df44e873d.
> 
> Conflicts:
> 
> 	configure.ac
> 	fb/fbpict.c
> 
> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
> ---
> Consensus on IRC was to just revert the broken change in server-1.7-branch.
> This change does that, but there were conflicts so I'd like somebody to
> review before I push it to server-1.7-nominations.

I tried the revert myself and got the same diff as you after resolving the
conflicts. I think it's good and I've pushed it to the 1.7-nominations
branch.

Cheers,
  Peter


More information about the xorg-devel mailing list