Nested pkg-config macros in configure.ac

Sat Nov 28 18:50:52 PST 2009

On Fri, 2009-11-27 at 14:37 -0800, Jeremy Huddleston wrote:

> looks like there's some bad pkg-config m4 macros being used here...  My guess is that the pkg-config macros don't like being nested:
> 
> ...
> checking dependency style of $(CC)... none
> checking for DMXMODULES... yes
> ./configure: line 28374: XDMXCONFIG_DEP_CFLAGS: command not found
> ./configure: line 28375: C: command not found
> ./configure: line 28376: XDMXCONFIG_DEP_LIBS: command not found
> ./configure: line 28377: linker: command not found
> checking for XDMXCONFIG_DEP... yes
> checking whether to build Xdmx DDX... no
> checking for sed... /opt/local/bin/gsed
> configure: creating ./config.status
> 
> ---
> 
> Here's the generated configure script around this area:
> 
> if test $pkg_failed = yes; then
> 
> if $PKG_CONFIG --atleast-pkgconfig-version 0.20; then
>         _pkg_short_errors_supported=yes
> else
>         _pkg_short_errors_supported=no
> fi
>         if test $_pkg_short_errors_supported = yes; then
>                 DMXMODULES_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors "xmuu $LIBXEXT x11 xrender xfixes xfont $LIBXI $DMXPROTO xau $XDMCP_MODULES" 2>&1`
>         else
>                 DMXMODULES_PKG_ERRORS=`$PKG_CONFIG --print-errors "xmuu $LIBXEXT x11 xrender xfixes xfont $LIBXI $DMXPROTO xau $XDMCP_MODULES" 2>&1`
>         fi
>         # Put the nasty error message in config.log where it belongs
>         echo "$DMXMODULES_PKG_ERRORS" >&5
> 
>         { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
> $as_echo "no" >&6; }
>                 have_dmx=no
> elif test $pkg_failed = untried; then
>         have_dmx=no
> else
>         DMXMODULES_CFLAGS=$pkg_cv_DMXMODULES_CFLAGS
>         DMXMODULES_LIBS=$pkg_cv_DMXMODULES_LIBS
>         { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
> $as_echo "yes" >&6; }
>           XDMXCONFIG_DEP_CFLAGS
>               C compiler flags for XDMXCONFIG_DEP, overriding pkg-config  
>   XDMXCONFIG_DEP_LIBS
>               linker flags for XDMXCONFIG_DEP, overriding pkg-config
> 
> pkg_failed=no
> { $as_echo "$as_me:${as_lineno-$LINENO}: checking for XDMXCONFIG_DEP" >&5
> $as_echo_n "checking for XDMXCONFIG_DEP... " >&6; }
> 
> 

I cloned xorg-xserver-1.7 and was able to reproduce the problem. The
nested invocation of PKG_CHECK_MODULES is a parameter and must be
quoted. This fixes the error. I was able to verify that when either xmuu
or xpm is missing, the result of "checking whether to build Xdmx DDX" is
no. I only verified the configuration part, I did not do a full build.

I have attached a patch that I created from branch 1.7, but that aspect
of things need to be verified. 

config.log:

configure:28311: checking for DMXMODULES
configure:28319: $PKG_CONFIG --exists --print-errors "xmuu $LIBXEXT x11
xrender xfixes xfont $LIBXI $DMXPROTO xau $XDMCP_MODULES"
configure:28322: $? = 0
configure:28337: $PKG_CONFIG --exists --print-errors "xmuu $LIBXEXT x11
xrender xfixes xfont $LIBXI $DMXPROTO xau $XDMCP_MODULES"
configure:28340: $? = 0
configure:28376: result: yes
configure:28380: checking for XDMXCONFIG_DEP
configure:28388: $PKG_CONFIG --exists --print-errors "xaw7 xmu xt xpm
x11"
configure:28391: $? = 0
configure:28406: $PKG_CONFIG --exists --print-errors "xaw7 xmu xt xpm
x11"
configure:28409: $? = 0
configure:28445: result: yes
configure:28450: checking whether to build Xdmx DDX
configure:28459: result: yes

> 
> 
> On Nov 26, 2009, at 22:00, Peter Hutterer wrote:
> 
> > The second stable update to the X server 1.7 is now available.
> > 
> > Only a few fixes went in since last week's RC2, the most prominent reverting
> > a regression. See Bug 25136 for more details.
> > 
> > I think the 5 week schedule worked out well, hence 1.7.3 is scheduled 5
> > weeks from now, with the snapshots after 2 and 4 weeks unless some other
> > reason forces us to release sooner.
> > 
> > Please remember to nominate your patches for 1.7 either by letting me know
> > over IRC/email or by shoving it into the server-1.7-nominations branch.
> > 
> > As usual, the shortlog below:
> > 
> > AaronsPlattner (1):
> >      Bug #25136: Revert "Fix clipping when windows are used as sources"
> > 
> > Jeremy Huddleston (1):
> >      XQuartz: Allow better compatability with older versions of xinit
> > 
> > Peter Hutterer (4):
> >      Xi: don't crash when deleting invalid device properties.
> >      Move xdmxconfig modules into DMX conditionals (#25102)
> >      Xi: when deleting all properties, reset property handler to NULL.
> >      xserver 1.7.2
> > 
> > Rami Ylimaki (1):
> >      Xext: Fix a memory leak on GE client disconnect.
> > 
> > Zhao Yakui (1):
> >      xfree86: Edid quirk for Philips LCD LP154W01
> > 
> > git tag: xorg-server-1.7.2
> > 
> > http://xorg.freedesktop.org/archive/individual/xserver/xorg-server-1.7.2.tar.bz2
> > MD5: 5c087e0f555203065fd90d02ef5f736e  xorg-server-1.7.2.tar.bz2
> > SHA1: b436d4b40d25c2d3dd638a96bb2cc7ae8b4e2648  xorg-server-1.7.2.tar.bz2
> > 
> > http://xorg.freedesktop.org/archive/individual/xserver/xorg-server-1.7.2.tar.gz
> > MD5: 7770f99952bed0131a27424c0efce87d  xorg-server-1.7.2.tar.gz
> > SHA1: 4bdf68c2317f13160b2f0018b8a07b7a8473c96c  xorg-server-1.7.2.tar.gz
> > 
> > _______________________________________________
> > xorg-announce mailing list
> > xorg-announce at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/xorg-announce
> 
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20091128/cfe4b8cd/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure.ac-error-while-checking-for-XDMXCONFIG_DE.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091128/cfe4b8cd/attachment.bin 