[PATCH libXext] Don't export xgeExtRegister

[Peter Hutterer]

On Sat, Nov 28, 2009 at 03:38:33PM +0100, Julien Cristau wrote:
> Its only caller is XextAddDisplay()
> ---
>  src/Xge.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/Xge.c b/src/Xge.c
> index 7a583e5..2ea5d27 100644
> --- a/src/Xge.c
> +++ b/src/Xge.c
> @@ -294,7 +294,7 @@ _xgeEventToWire(Display* dpy, XEvent* re, xEvent* event)
>  /*
>   * Extensions need to register callbacks for their events.
>   */
> -Bool
> +_X_HIDDEN Bool
>  xgeExtRegister(Display* dpy, int offset, XExtensionHooks* callbacks)
>  {
>      XGEExtNode* newExt;
> -- 
> 1.6.5

xgeExtRegister is defined here but declared in extutil.c.

the gcc docs recommend adding attributes to the declaration:
"The visibility attribute should be applied only to declarations which would
otherwise have external linkage. [...]"
http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#Function-Attributes

I think it'd be better to move the attribute to extutil.c then. given that
change,
Acked-by: Peter Hutterer <peter.hutterer at who-t.net>

Cheers,
  Peter