[PULL] memory leak fixes and a build fix

Keith Packard keithp at keithp.com
Mon Nov 30 01:32:53 PST 2009


On Mon, 30 Nov 2009 14:37:28 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:

> Gaetan Nadon (1):
>       configure.ac: error while checking for XDMXCONFIG_DEP

No S-o-b line from Gaetan? I found a few other commits missing S-o-b
lines from the author recently; looks like I need to be more careful.

> Peter Hutterer (3):
>       dix: fix memory leak, free event list on shutdown. (#25028)

I'd rather see this as:

    FreeEventList(InputEventList, InputEventListLen);
    InputEventList = NULL;
    InputEventListLen = 0;

As you can see, the bug was caused by an open-coded copy of FreeEventList.

>       dix: remove some obsolete comment.

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix: remove core devices when shutting down. (#25028)

Reviewed-by: Keith Packard <keithp at keithp.com>

(A bit ugly, but meh)

>  configure.ac  |   14 +++++++++-----
>  dix/devices.c |    4 +++-
>  dix/events.c  |    2 ++
>  3 files changed, 14 insertions(+), 6 deletions(-)

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091130/d2ab35db/attachment.pgp 


More information about the xorg-devel mailing list