[PATCH] Bug #25136: Revert "Fix clipping when windows are used as sources"

Keith Packard keithp at keithp.com
Mon Nov 30 08:46:51 PST 2009

On 30 Nov 2009 15:52:20 +0100, Soeren Sandmann <sandmann at daimi.au.dk> wrote:

> If you clip to the screen pixmap, then you will need to adjust the
> transformation to account for the coordinates of the drawable no
> longer being right. Or ignore it, as you say.

That doesn't sound terribly difficult to me. It should just be a matter
of adjusting the transform elements of the matrix (as the transform is
From dest to source). Should take a couple of adds.

> The crash (and security hole - because you can write outside the
> screen too) was introduced by reverting the copying patch. Before
> that, with the Fedora patch, it was correct, just really slow in one
> case.

I guess I'm still confused then -- at some point you have to restrict
access to pixels within some pixmap; how is this getting skipped in this

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091130/531d560c/attachment-0001.pgp 

More information about the xorg-devel mailing list