[PATCH] Replace miPointerCurrentScreen with miPointerGetScreen.

Daniel Stone daniel at fooishbar.org
Sat Oct 3 18:03:14 PDT 2009


On Fri, Oct 02, 2009 at 02:54:57PM -0700, Jamey Sharp wrote:
> I get the impression from glancing at the code that you're right, but
> xf86RandRSetConfig begins with
> 	miPointerGetPosition(inputInfo.pointer, &px, &py);
> and this if block ends with
> 	(*pScreen->SetCursorPosition) (inputInfo.pointer, pScreen, ...
> so there's quite a bit more involved in such a change.
> Meanwhile, this simple patch at least makes this call consistent with
> the two near it, and fixes the compiler warning.

To be honest, I'd rather keep the warning in this case, so we know that
the code needs to be fixed.

> I suspect most of this code could go away anyway, in a world where
> people rarely use viewport panning. I'd guess the real problem is that
> xf86SwitchMode goes to a bunch of trouble to move all the pointers
> around and then this function feebly attempts to put one of them back.

The panning code is new. :\

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091004/5ba6357c/attachment.pgp 

More information about the xorg-devel mailing list