[PATCH] Use PRId32/PRIx32 from inttypes.h for printf of CARD32 values.

[Thomas Dickey]

On Sun, 4 Oct 2009, Mark Kettenis wrote:

>>> @@ -219,7 +219,7 @@ port_rep_inb(xf86Int10InfoPtr pInt,
>>>      register int inc =3D d_f ? -1 : 1;
>>>      CARD32 dst =3D base;
>>>      if (PRINT_PORT && DEBUG_IO_TRACE())
>>> -	ErrorF(" rep_insb(%#x) %ld bytes at %8.8lx %s\n",
>>> +	ErrorF(" rep_insb(%#x) %" PRId32 " bytes at %8.8" PRIx32 " %s\n",
>>>  		port, count, base, d_f ? "up" : "down");
>>>      while (count--) {
>>>  	MEM_WB(pInt, dst, x_inb(port));
>>
>> Is this portable beyond glibc? Alan? Matthieu?
>
> The PRId32 and PRIx32 defines are part of C99.
>
> That said, the consensus among many groups of developers is that they
> are ugly, make the code harder to read and can be easily avoided by
> using appropriate casts.

beyond being merely ugly, different versions of gcc give warnings for
combinations that are quiet in other versions of gcc.

* something to consider for developers who do port code...

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net