[PATCH] Cast small-int values through intptr_t when they're passed as pointers.

Matthieu Herrb matthieu.herrb at laas.fr
Sun Oct 4 08:57:04 PDT 2009

Matthieu Herrb wrote:
> Daniel Stone wrote:
>> On Fri, Oct 02, 2009 at 01:42:50PM -0700, Jamey Sharp wrote:
>>> On 64-bit systems, int and pointers don't have the same size, so GCC gives
>>> warnings about casts between int and pointer types. However, in the cases
>>> covered by this patch, it's always a value that fits in int being stored
>>> temporarily as a pointer and then converted back later, which is safe.
>>> Casting through the pointer-sized integer type intptr_t convinces the
>>> compiler that this is OK.
>>> Signed-off-by: Jamey Sharp <jamey at minilop.net>
>> Alan, Matthieu -- is this portable enough?
> OpenBSD has intptr_t. But afaik there's a mess between different systems
> to find out which header provide the definition.
> I haven't tried to build an xserver with tht patch yet. I'll check that
> later today.

Yes this patch is ok for OpenBSD.

Matthieu Herrb

More information about the xorg-devel mailing list