[RFC PATCH] Initial libudev input-hotplug support

Daniel Stone daniel at fooishbar.org
Tue Oct 6 08:33:30 PDT 2009


On Tue, Oct 06, 2009 at 11:26:37AM -0400, Adam Jackson wrote:
> On Tue, 2009-10-06 at 13:22 +0200, Julien Cristau wrote:
> > On Mon, Oct  5, 2009 at 14:13:39 -0400, Adam Jackson wrote:
> > > I don't think the timer should be needed for libudev.  All
> > > udev_monitor_new_from_netlink() does aside from malloc() is open a
> > > netlink socket.  If that fails you have a plethora of more serious
> > > problems already.
> > > 
> > udev_monitor_new_from_netlink is called on init, but I can't call
> > AddGeneralSocket from there, or actually add the input devices, because
> > config_init() is called too early for that.  Is there a way besides the
> > timer to schedule this to happen when the server is actually ready?
> 
> Could just move config_init() after CreateWellKnownSockets().  Which
> seems like the right thing to do anyway; servers without input devices
> are perfectly valid, but servers without sockets are not, so we should
> init sockets first.

Seems fair, yeah.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091007/ebed1f59/attachment.pgp 


More information about the xorg-devel mailing list