[PATCH] Fix overlay detection when matching Xv adaptors across screens.

Keith Packard keithp at keithp.com
Wed Oct 7 10:42:07 PDT 2009


Excerpts from Jamey Sharp's message of Wed Oct 07 09:07:03 -0700 2009:
> Signed-off-by: Jamey Sharp <jamey at minilop.net>
> ---
> I don't know much about Xv or have any idea how to test this, but surely
> this loop is broken without this patch?
> 
>  Xext/xvdisp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Xext/xvdisp.c b/Xext/xvdisp.c
> index 04cd11a..5229916 100644
> --- a/Xext/xvdisp.c
> +++ b/Xext/xvdisp.c
> @@ -1912,7 +1912,7 @@ void XineramifyXv(void)
>          if((pAdapt->type & XvImageMask) && (pAdapt->nImages > 0)) {
>            hasOverlay = FALSE;
>                for(l = 0; l < pAdapt->nAttributes; l++) {
> -             if(!strcmp(pAdapt->name, "XV_COLORKEY")) {
> +             if(!strcmp(pAdapt->pAttributes[l].name, "XV_COLORKEY")) {
>             hasOverlay = TRUE;
>             break;
>           }

Looks reasonable to me; anyone with an overlay who might test this patch?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091007/97a8ecee/attachment-0001.pgp 


More information about the xorg-devel mailing list