[PATCH] Rootless: Abstract some of the Xplugin specific stuff which has crept into rootlessWindow.c

Jeremy Huddleston jeremyhu at freedesktop.org
Fri Oct 9 19:44:08 PDT 2009

On Oct 9, 2009, at 11:13, Jon TURNEY wrote:

> The rootless extension now directly calls some Xplugin functions,  
> and relies
> on types defined in Xplugin.h, which isn't very abstracted :-)
> This patch is a start at abstracting some of the Xplugin specific  
> stuff which
> has crept into rootlessWindow.c.  This has been done in a pretty  
> mindless fashion,
> without much thought as to if the additions to the generic rootless  
> interface are
> the correct ones
> There is some confusion as to if RootlesscolormapCallback() returns  
> a Bool or
> xp_error_enum value (not so abstact), but I have no way of checking,  
> of finding
> out if Xplugin actually checks the result :-)

Yes... erm... please don't breathe too hard when you look at miext/ 
rootless.  The condensation in your breath might cause it to all  

The RootlessColormapCallback bit is actually "correct" the way it  
was.  Success == 0, and the failure != 0... so your patch actually  
inverts the returned value (something that caused me a few weeks of  
pain to debug) ... and yes, not patch in a particularly elegant way...  

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3333 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091009/77178145/attachment.bin 

More information about the xorg-devel mailing list