[PATCH] Rootless: src drawable window can now be NULL
jeremyhu at freedesktop.org
Tue Oct 13 09:25:33 PDT 2009
That looks like a sane enough sanity check... but why was pSrc-
>pDrawable NULL in the first place?
I'll check it out on XQuartz later today.
On Oct 13, 2009, at 01:45, Colin Harrison wrote:
> This is one for Jeremy Huddleston and Jon Turney.
> Found when testing rootless modes in Xming using the new xeyes (uses
> to anti-alias).
> Patch to fix the crash and make it work...
> --- ./xserver/miext/rootless/rootlessScreen.c 2009-08-23
> 10:10:35.000000000 +0100
> +++ ./test/miext/rootless/rootlessScreen.c 2009-10-13
> 09:34:49.000000000 +0100
> @@ -257,8 +257,9 @@ RootlessComposite(CARD8 op, PicturePtr p
> maskWin = (pMask->pDrawable->type == DRAWABLE_WINDOW) ?
> (WindowPtr)pMask->pDrawable : NULL;
> - srcWin = (pSrc->pDrawable->type == DRAWABLE_WINDOW) ?
> - (WindowPtr)pSrc->pDrawable : NULL;
> + if (!pSrc->pDrawable) srcWin = NULL;
> + else srcWin = (pSrc->pDrawable->type == DRAWABLE_WINDOW) ?
> + (WindowPtr)pSrc->pDrawable : NULL;
> dstWin = (pDst->pDrawable->type == DRAWABLE_WINDOW) ?
> (WindowPtr)pDst->pDrawable : NULL;
> Colin Harrison
> xorg-devel mailing list
> xorg-devel at lists.x.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3333 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091013/a3447843/attachment.bin
More information about the xorg-devel