[PATCH v3] Add libgcrypt as an option for sha1

Rémi Cardona remi at gentoo.org
Wed Oct 14 16:08:41 PDT 2009

Le 15/10/2009 00:47, Julien Cristau a écrit :
> On Sun, Oct  4, 2009 at 23:21:31 +1100, Daniel Stone wrote:
>> If you break it all out into separate utility functions in os/ or dix/
>> (e.g. [0] or similar) and document the result at least in the header
>> file you add it to, I'll even test it. :)
> See attached patches.  Patch #1 adds x_sha1_{init,update,final}() to os/
> and makes render use that.  Patch #2 adds the --with-sha1= option, and
> #3 adds libgcrypt.

In Patch #1, in os/Makefile.am, why not use $(SHA1_CFLAGS) instead of 
@SHA1_CFLAGS@? Just seems odd.

But other than that, the patches look good and are crystal clear.

Reviewed-by: Rémi Cardona <remi at gentoo.org>


More information about the xorg-devel mailing list